fix: refresh Claude live config after common updates during takeover#339
Open
mydelren wants to merge 1 commit into
Open
fix: refresh Claude live config after common updates during takeover#339mydelren wants to merge 1 commit into
mydelren wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When Claude takeover is already active, updating Claude common config can persist the snippet in cc-switch while leaving the active live config stale.
In practice this means fields like
statusLine(or simpler env keys) can exist in Claude common config but never appear in~/.claude/settings.jsonuntil some later operation rewrites live config.Root cause addressed here
The takeover-active post-commit path used
ProxyLiveBackupand saved a refreshed backup snapshot, but it did not refresh the active Claude live config. It also rebuilt backup state from the stored common snippet instead of the in-flight snippet being applied by the current operation.This patch:
Verification
Already verified locally before preparing this PR:
cargo build --libprovider_commandsintegration testsRegression coverage
Added:
updating_claude_common_config_under_takeover_refreshes_active_live_settingsIssue
Closes #338