Skip to content

Fix showing images of a member sometimes when showing room icons#978

Merged
nushea merged 3 commits into
devfrom
fix-pfp-letter
Jun 22, 2026
Merged

Fix showing images of a member sometimes when showing room icons#978
nushea merged 3 commits into
devfrom
fix-pfp-letter

Conversation

@nushea

@nushea nushea commented Jun 22, 2026

Copy link
Copy Markdown
Member

Description

Fix showing images of a member sometimes when showing room icons and add view for showing icons when available and not any other time and change default to it.

image

Fixes #963
Fixes #962

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

Written with the assistance of a kneading eraser used as a stimming tool

Signed-off-by: Shea <nu@she-a.eu>
@nushea nushea marked this pull request as ready for review June 22, 2026 04:44
@nushea nushea requested review from 7w1 and hazre as code owners June 22, 2026 04:44
@nushea nushea changed the title Fix pfp letter Fix showing images of a member sometimes when showing room icons Jun 22, 2026
@nushea nushea marked this pull request as draft June 22, 2026 07:32
Signed-off-by: Shea <nu@she-a.eu>
@nushea nushea marked this pull request as ready for review June 22, 2026 08:23
Signed-off-by: Shea <nu@she-a.eu>
@github-actions

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-978-sable.raspy-dream-bb1d.workers.dev 4f98871 pr-978 Mon, 22 Jun 2026 09:29:58 GMT

@nushea nushea added this pull request to the merge queue Jun 22, 2026
Merged via the queue into dev with commit 2cdbb03 Jun 22, 2026
12 checks passed
@nushea nushea deleted the fix-pfp-letter branch June 22, 2026 17:30
charm-cloudhub-social Bot pushed a commit to CloudHub-Social/Charm-1.0 that referenced this pull request Jul 9, 2026
> [!IMPORTANT]
> Merging this PR will create a new release.

## Features

* Added a GIF search functionality
([SableClient#970](<SableClient#970>) by @7w1,
@nikiwastaken)
* Change unverified device flow.
([SableClient#1017](<SableClient#1017>) by
@nikiwastaken, @nushea)
* Change animal identity to allow arbitrary animals
([SableClient#984](<SableClient#984>) by @nushea)
* Add a new Mobile Context
([SableClient#946](<SableClient#946>) by @7w1,
@nushea)
* Add bookmark functionality using account data
([SableClient#1000](<SableClient#1000>) by
@nikiwastaken, @nushea)
* Add Copy Message button to copy unformatted version.
([SableClient#1001](<SableClient#1001>) by @nushea)
* Change profile handle part to a button that copies it
([SableClient#981](<SableClient#981>) by @nushea)
* Add reactions to arbitrary events
([SableClient#946](<SableClient#946>) by @7w1,
@nushea)
* Added a gallery support as per msc4274
([SableClient#1019](<SableClient#1019>) by
@nikiwastaken, @nushea)
* Add a context menu for copying and downloading images.
([SableClient#994](<SableClient#994>) by
@nikiwastaken, @nushea)
* Add search message keybind and combine sidebar items.
([SableClient#943](<SableClient#943>) by @nushea)
* Add option for showing icons only when available and changed default
to it ([SableClient#978](<SableClient#978>) by
@nushea)
* Add CTRL+E shortcut to editor to bring sticker menu up
([SableClient#982](<SableClient#982>) by @nushea)
* Redesign the user menu tab
([SableClient#990](<SableClient#990>) by
@nikiwastaken, @nushea)
* Modify large parts of the mobile view of Sable!
([SableClient#1017](<SableClient#1017>) by
@nikiwastaken, @nushea)
* Improved sliding sync (only requests specific room state data),
cleaned up and fixed most flickering issues, and added buttons in
developer tools to request full state.
([SableClient#1020](<SableClient#1020>) by @7w1)

### Revamped the calling experience in Sable!
([SableClient#841](<SableClient#841>) by @7w1)

- Pulled the latest Element Call updates.
- Style improvements to the call widget so it uses the Sable theme and
fonts.
- Added support for custom ringtones and ringbacks.
- Added call permissions.
- Fixed various bugs around call ending, declining, and joining.

## Fixes

* Allow favoriting all animated attachment types
([SableClient#1029](<SableClient#1029>) by
@nikiwastaken)
* Updated emojis to use stable 1.19 identifiers
([SableClient#1034](<SableClient#1034>) by @7w1)
* Swap to using the stable identifier `m.recent_emoji` for recent emojis
and add migration logic.
([SableClient#1009](<SableClient#1009>) by @7w1)
* Add a direct link to room/space settings when the current sticker list
is empty ([SableClient#1016](<SableClient#1016>) by
@7w1, @ellieplayswow)
* Fix leaving modal looking outsized
([SableClient#991](<SableClient#991>) by @nushea)
* Fix cat status not being present on its own.
([SableClient#971](<SableClient#971>) by
@nikiwastaken)
* Fix encrypted thread messages not appearing until reopened.
([SableClient#975](<SableClient#975>) by @7w1)
* Fix codebase issues with gadient themes
([SableClient#1007](<SableClient#1007>) by @nushea)
* Fix account switcher's add account button redirecting to the wrong
path when hashRouter is enabled
([SableClient#993](<SableClient#993>) by
@EphemeralFog)
* Fix the image viewer header not being fully visible on smaller phone
screens. ([SableClient#1035](<SableClient#1035>) by
@7w1)
* Fix mentions not sending in non-textual replies
([SableClient#1004](<SableClient#1004>) by @nushea)
* Fixed oidc device delete key being incorrect.
([SableClient#1030](<SableClient#1030>) by @7w1)
* Fix crash when opening pins with stickers.
([SableClient#972](<SableClient#972>) by @7w1)
* Fix pixelated image scaling not pixelating when zoomed in.
([SableClient#1033](<SableClient#1033>) by @7w1)
* Fix registration not working when accessed from add account button
([SableClient#992](<SableClient#992>) by
@EphemeralFog)
* Reverse the order of message header elements in the right aligned
bubbles layout. ([SableClient#967](<SableClient#967>)
by @EphemeralFog)
* Fixed outdated Firefox versions and some Safari versions not being
able to send messages.
([SableClient#1010](<SableClient#1010>) by @7w1)
* Fix timeline sorting order regression when "show hidden events" is
enabled. ([SableClient#974](<SableClient#974>) by
@7w1)
* Fix ghost quickmenu
([SableClient#946](<SableClient#946>) by @7w1,
@nushea)
* Fix Collapsed mode showing the wrong icon
([SableClient#978](<SableClient#978>) by @nushea)
* Fix poll crashing sable if interacted with different clients
([SableClient#969](<SableClient#969>) by @nushea)
* Fix video player sometimes not working
([SableClient#1031](<SableClient#1031>) by @nushea)
* Add support for searching users via nicknames in the autocomplete
menu. ([SableClient#1028](<SableClient#1028>) by
@7w1)
* Update `@sableclient/twemoji-font` to fix missing Twemoji emoji
coverage. ([SableClient#964](<SableClient#964>) by
@7w1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants