Skip to content

feat(ohos): implement privacy and anonymous feedback #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SWangHash merged 1 commit into from
Aug 5, 2026
Merged

feat(ohos): implement privacy and anonymous feedback #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
"desktop:preview:debug": "node scripts/dev.cjs desktop-preview",
"desktop:dev:raw": "cross-env-shell CI=true \"cd src/apps/desktop && tauri dev\"",
"target:gc": "node scripts/cargo-target-gc.mjs",
"feedback:mock": "node scripts/feedback-mock-server.mjs",
"desktop:build": "node scripts/desktop-tauri-build.mjs",
"desktop:build:fast": "node scripts/desktop-tauri-build.mjs --debug --no-bundle",
"desktop:build:release-fast": "node scripts/desktop-tauri-build.mjs --no-bundle -- --profile release-fast --features devtools",
Expand Down
21 changes: 11 additions & 10 deletions scripts/core-boundaries/rules/feature-rules.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,26 +57,26 @@ export const optionalDependencyFeatureOwnerRules = [
'services-integrations optional runtime dependencies must stay owned by explicit integration features',
dependencies: [
{ depName: 'aes', ownerFeatures: ['remote-connect'] },
{ depName: 'aes-gcm', ownerFeatures: ['mcp', 'remote-connect', 'remote-ssh-concrete'] },
{ depName: 'anyhow', ownerFeatures: ['browser-control', 'debug-log', 'mcp', 'remote-connect', 'remote-ssh', 'remote-ssh-concrete'] },
{ depName: 'aes-gcm', ownerFeatures: ['feedback', 'mcp', 'remote-connect', 'remote-ssh-concrete'] },
{ depName: 'anyhow', ownerFeatures: ['browser-control', 'debug-log', 'feedback', 'mcp', 'remote-connect', 'remote-ssh', 'remote-ssh-concrete'] },
{
depName: 'async-trait',
ownerFeatures: ['mcp', 'remote-connect', 'remote-ssh', 'remote-ssh-concrete', 'review-platform', 'script-tool-runtime', 'speech', 'workspace-search'],
ownerFeatures: ['feedback', 'mcp', 'remote-connect', 'remote-ssh', 'remote-ssh-concrete', 'review-platform', 'script-tool-runtime', 'speech', 'workspace-search'],
},
{
depName: 'base64',
ownerFeatures: ['mcp', 'miniapp-runtime', 'remote-connect', 'remote-ssh-concrete', 'speech'],
ownerFeatures: ['feedback', 'mcp', 'miniapp-runtime', 'remote-connect', 'remote-ssh-concrete', 'speech'],
},
{ depName: 'bitfun-agent-runtime', ownerFeatures: ['deep-research'] },
{ depName: 'bitfun-core-types', ownerFeatures: ['speech'] },
{ depName: 'bitfun-product-domains', ownerFeatures: ['canvas-runtime', 'function-agents', 'miniapp-runtime', 'plugin-source'] },
{ depName: 'bitfun-product-domains', ownerFeatures: ['canvas-runtime', 'feedback', 'function-agents', 'miniapp-runtime', 'plugin-source', 'privacy'] },
{ depName: 'bitfun-runtime-ports', ownerFeatures: ['remote-connect', 'remote-ssh', 'remote-ssh-concrete', 'script-tool-runtime'] },
{
depName: 'bitfun-services-core',
ownerFeatures: ['browser-control', 'git', 'mcp', 'miniapp-runtime', 'process-tree', 'remote-connect', 'review-platform', 'workspace-search'],
},
{ depName: 'bzip2', ownerFeatures: ['speech'] },
{ depName: 'chrono', ownerFeatures: ['debug-log', 'git', 'remote-connect', 'remote-ssh-concrete', 'review-platform', 'speech'] },
{ depName: 'chrono', ownerFeatures: ['debug-log', 'feedback', 'git', 'privacy', 'remote-connect', 'remote-ssh-concrete', 'review-platform', 'speech'] },
{ depName: 'dirs', ownerFeatures: ['browser-control', 'miniapp-runtime', 'remote-connect', 'remote-ssh-concrete'] },
{ depName: 'dunce', ownerFeatures: ['plugin-source', 'remote-ssh', 'workspace-search'] },
{ depName: 'fs2', ownerFeatures: ['plugin-source'] },
Expand All @@ -93,19 +93,19 @@ export const optionalDependencyFeatureOwnerRules = [
{ depName: 'notify', ownerFeatures: ['file-watch'] },
{ depName: 'oxc', ownerFeatures: ['canvas-runtime'] },
{ depName: 'qrcode', ownerFeatures: ['remote-connect'] },
{ depName: 'rand', ownerFeatures: ['mcp', 'remote-connect', 'remote-ssh-concrete'] },
{ depName: 'rand', ownerFeatures: ['feedback', 'mcp', 'remote-connect', 'remote-ssh-concrete'] },
// remote-ssh-concrete: one-click relay deploy fetches the signed release
// checksum over HTTPS and verifies it on this device, because the target
// server has no minisign and no trust root of its own.
{ depName: 'reqwest', ownerFeatures: ['announcement', 'browser-control', 'debug-log', 'mcp', 'miniapp-runtime', 'remote-connect', 'remote-ssh-concrete', 'review-platform', 'speech', 'web-tools'] },
{ depName: 'reqwest', ownerFeatures: ['announcement', 'browser-control', 'debug-log', 'feedback', 'mcp', 'miniapp-runtime', 'remote-connect', 'remote-ssh-concrete', 'review-platform', 'speech', 'web-tools'] },
{ depName: 'rmcp', ownerFeatures: ['mcp'] },
{ depName: 'russh', ownerFeatures: ['remote-ssh-concrete'] },
{ depName: 'russh-keys', ownerFeatures: ['remote-ssh-concrete'] },
{ depName: 'russh-sftp', ownerFeatures: ['remote-ssh-concrete'] },
{ depName: 'rustls', ownerFeatures: ['remote-connect'] },
{ depName: 'rustls-native-certs', ownerFeatures: ['remote-connect'] },
{ depName: 'schannel', ownerFeatures: ['remote-connect'] },
{ depName: 'sha2', ownerFeatures: ['canvas-runtime', 'plugin-source', 'remote-connect', 'remote-ssh', 'review-platform', 'speech'] },
{ depName: 'sha2', ownerFeatures: ['canvas-runtime', 'feedback', 'plugin-source', 'privacy', 'remote-connect', 'remote-ssh', 'review-platform', 'speech'] },
{ depName: 'sherpa-onnx', ownerFeatures: ['speech'] },
{ depName: 'shellexpand', ownerFeatures: ['remote-ssh-concrete'] },
{ depName: 'sse-stream', ownerFeatures: ['mcp'] },
Expand All @@ -116,7 +116,7 @@ export const optionalDependencyFeatureOwnerRules = [
{ depName: 'tokio-tungstenite', ownerFeatures: ['remote-connect'] },
{ depName: 'tokio-util', ownerFeatures: ['remote-ssh', 'speech'] },
{ depName: 'urlencoding', ownerFeatures: ['canvas-runtime', 'remote-connect', 'review-platform'] },
{ depName: 'uuid', ownerFeatures: ['canvas-runtime', 'debug-log', 'miniapp-runtime', 'plugin-source', 'remote-connect', 'remote-ssh-concrete', 'speech'] },
{ depName: 'uuid', ownerFeatures: ['canvas-runtime', 'debug-log', 'feedback', 'miniapp-runtime', 'plugin-source', 'remote-connect', 'remote-ssh-concrete', 'speech'] },
{ depName: 'which', ownerFeatures: ['miniapp-runtime', 'remote-connect', 'script-tool-runtime', 'workspace-search'] },
{ depName: 'windows', ownerFeatures: ['plugin-source', 'review-platform'] },
{ depName: 'x25519-dalek', ownerFeatures: ['remote-connect'] },
Expand Down Expand Up @@ -212,6 +212,7 @@ export const ownerCrateFeatureAssemblyRules = [
'debug-log',
'deep-research',
'file-watch',
'feedback',
'function-agents',
'git',
'miniapp-runtime',
Expand Down
28 changes: 28 additions & 0 deletions scripts/core-boundaries/self-test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,34 @@ export function runManifestParserSelfTest({
const servicesOptionalOwnerDeps = new Set(
servicesOptionalOwnerRule?.dependencies.map((dependency) => dependency.depName) ?? [],
);

const expectedFeatureDependencies = {
feedback: [
'aes-gcm',
'anyhow',
'async-trait',
'base64',
'bitfun-product-domains',
'chrono',
'rand',
'reqwest',
'sha2',
'uuid',
],
privacy: ['bitfun-product-domains', 'chrono', 'sha2'],
};
for (const [featureName, dependencies] of Object.entries(expectedFeatureDependencies)) {
for (const dep of dependencies) {
const owner = servicesOptionalOwnerRule?.dependencies.find(
(dependency) => dependency.depName === dep,
);
if (!owner?.ownerFeatures.includes(featureName)) {
throw new Error(
`services-integrations ${featureName} must own optional dependency ${dep}`,
);
}
}
}
for (const dep of servicesIntegrationsDefaultProfile?.forbiddenNonOptionalDeps ?? []) {
if (!servicesOptionalOwnerDeps.has(dep)) {
throw new Error(
Expand Down
Loading
Loading