This repository was archived by the owner on Oct 29, 2019. It is now read-only.
init: added check for ldap#722
Open
vitoravelino wants to merge 1 commit into
Open
Conversation
vitoravelino
commented
Feb 1, 2019
vitoravelino
force-pushed
the
check-ldap-init
branch
from
84e6d07 to
0840ebc
Compare
mssola
suggested changes
Feb 1, 2019
flavio
suggested changes
Feb 6, 2019
flavio
left a comment
flavio
left a comment
Member
There was a problem hiding this comment.
Overall LGTM, just update the error handling as requested by Miquel.
vitoravelino
force-pushed
the
check-ldap-init
branch
from
0840ebc to
306f5c0
Compare
Contributor
Author
|
I've realized that I added the check to the wrong file. It should be checked in the |
mssola
previously approved these changes
Feb 7, 2019
Added a new check to verify if the ldap instance is ready before running velum dashboard in order to avoid a connection error when creating a new user. Signed-off-by: Vítor Avelino <vavelino@suse.com> bsc#1121064
vitoravelino
force-pushed
the
check-ldap-init
branch
from
306f5c0 to
cbcff75
Compare
MalloZup
approved these changes
Mar 8, 2019
MalloZup
left a comment
MalloZup
left a comment
Contributor
There was a problem hiding this comment.
Thx Vito. Lgtm please retrigger the ci and pray, (from famous book eat pray love and retrigger Ci)
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new check to verify if the ldap instance is ready before running
velum dashboard in order to avoid a connection error when creating a new
user.
Signed-off-by: Vítor Avelino vavelino@suse.com
bsc#1121064