Remove deprecated SCF tests - #143
Open
HartS wants to merge 1 commit into
Open
Conversation
These tests aren't referenced from Makefile, and are no longer relevant with kubecf.
Contributor
|
Those tests are for catapult itself. You can run them with |
Member
|
The unit and integration tests contain things that are not only scf, for example the buildir creation, downloading of needed binaries, backend unit tests, stratos, and stratos-metrics. I would be glad to remove them, but I don't think we should remove unit and integration tests unless we remove the code that they test, and in the case of scf, we should have an alternative in place before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests aren't referenced from Makefile, and are no longer relevant with
kubecf.