feat: add multi option for priority queryParam#330
Merged
Conversation
rhuam
reviewed
May 27, 2024
| value: data.priority, | ||
| } | ||
| : null, | ||
| priority: [], |
Contributor
There was a problem hiding this comment.
Colocar o valor inicial para persistir o filtro quando o usuário fechar e abrir novamente.
Contributor
Author
There was a problem hiding this comment.
Olá @rhuam, existem algumas outras issues que estão sendo desenvolvidas especialmente para esse item, será que não seria melhor deixar essa implementação com apenas a opção de simultaneidade do filtro de prioridade?
Relacionados:
Contributor
There was a problem hiding this comment.
@diegodario88 acredito que o @rhuam quis dizer isso aqui
priority: data.priority?.split(',') || []
Contributor
Author
There was a problem hiding this comment.
@rodrigooler perfeito, eu implementei conforme a sugestão. Por favor revise novamente
Screencast.from.2024-05-28.16-17-26.mp4
rodrigooler
approved these changes
May 27, 2024
rodrigooler
left a comment
rodrigooler
left a comment
Contributor
There was a problem hiding this comment.
Aparentemente está OK, bom trabalho!
diegodario88
force-pushed
the
filtro-shelters
branch
2 times, most recently
from
bf42e8b to
558b17f
Compare
diegodario88
force-pushed
the
filtro-shelters
branch
from
558b17f to
aeb8822
Compare
rodrigooler
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR para issue -> SOS-RS/backend#145