⚡ Implement ThreadLocal Mac caching in CryptoHelper#8
Conversation
Co-authored-by: SirDank <52797753+SirDank@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: A
ThreadLocal<Mac>caching"HmacSHA1"instances was implemented, replacing repetitive calls toMac.getInstance("HmacSHA1")insymmetricDecryptHMACIVandsymmetricEncryptWithHMACIVwith aget()call to the thread-local instance.🎯 Why:
Mac.getInstanceinvolves significant overhead on each instantiation. Reusing an initializedMacviaThreadLocalsafely bypasses this overhead without side effects, asMac.init()successfully resets state for subsequent operations.📊 Measured Improvement:
We measured symmetric decrypt and symmetric encrypt loops (100,000 iterations each):
PR created automatically by Jules for task 13530190269420780569 started by @SirDank