Skip to content

🔒 Fix plaintext storage of credentials by implementing AES encryption#3

Open
SirDank wants to merge 1 commit into
mainfrom
fix/aes-encrypt-credential-store-6739107926798605219
Open

🔒 Fix plaintext storage of credentials by implementing AES encryption#3
SirDank wants to merge 1 commit into
mainfrom
fix/aes-encrypt-credential-store-6739107926798605219

Conversation

@SirDank

@SirDank SirDank commented May 27, 2026

Copy link
Copy Markdown
Contributor

🎯 What: The vulnerability fixed
Sensitive credential data (Steam refresh token) was being stored as plaintext in FileCredentialStore.java using Files.writeString, making it vulnerable to unauthorized access on the local filesystem.

⚠️ Risk: The potential impact if left unfixed
If the file system permissions were bypassed or misconfigured, or if the user's filesystem was compromised, the plaintext refresh tokens could be extracted and used to impersonate the user or access their Steam account without their knowledge.

🛡️ Solution: How the fix addresses the vulnerability
Implemented AES-128 GCM encryption and decryption in FileCredentialStore.java using the JDK's standard security providers.

  • A secure 128-bit AES key is randomly generated using KeyGenerator upon first use and securely stored via the Java Preferences API (Preferences.userNodeForPackage(FileCredentialStore.class)).
  • Before saving the refresh token, the data is encrypted using AES/GCM/NoPadding. A random 12-byte IV is securely generated and prepended to the ciphertext, which is then Base64-encoded.
  • When loading the credentials, the Base64 input is decoded, the IV is extracted, and the data is decrypted using the AES key.
  • To ensure backwards compatibility with existing legacy credentials, a fallback mechanism is included in load(). If decryption fails (e.g. because it's a plaintext credential), it returns the plaintext string. Upon subsequent saves, it will automatically be encrypted.

Rationale: No tests were added since the codebase lacks a unit testing framework and test directory setup. Sanity checking and Maven test commands were successful, confirming no existing logic regressions.


PR created automatically by Jules for task 6739107926798605219 started by @SirDank

Implemented AES-128 GCM encryption in `FileCredentialStore.java`. The
AES key is randomly generated and securely stored via Java Preferences
API upon first use. This prevents storing Steam refresh tokens as
plaintext on the filesystem. Implemented a transparent fallback to read
legacy plaintext tokens during load, which will be automatically encrypted
upon re-save.

Co-authored-by: SirDank <52797753+SirDank@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant