Skip to content

⚡ [Performance] Avoid object allocation in TouchButtonView.onDraw #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SirDank wants to merge 1 commit into from
Closed

⚡ [Performance] Avoid object allocation in TouchButtonView.onDraw #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions launcher/app/src/main/java/com/skarm/launcher/touch/TouchControlViews.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,12 +222,14 @@ class TouchButtonView(context: Context, node: ControlNode) : BaseTouchControl(co
private var isPressedState = false
private var isToggledOn = false

private val buttonRect = RectF()

override fun onDraw(canvas: Canvas) {
val centerX = width / 2f
val centerY = height / 2f
val size = min(width, height).toFloat()

val rect = RectF(
buttonRect.set(
centerX - size / 2f,
centerY - size / 2f,
centerX + size / 2f,
Expand All @@ -238,7 +240,7 @@ class TouchButtonView(context: Context, node: ControlNode) : BaseTouchControl(co

// Use a rounded square instead of a circle
val cornerRadius = size * 0.25f
canvas.drawRoundRect(rect, cornerRadius, cornerRadius, bgPaint)
canvas.drawRoundRect(buttonRect, cornerRadius, cornerRadius, bgPaint)

// Draw label
if (node.label.isNotEmpty()) {
Expand Down
Loading