Holo housekeeping: update contact email, wire up classifier in example notebook#392
Open
animmosmith wants to merge 2 commits into
Open
Holo housekeeping: update contact email, wire up classifier in example notebook#392animmosmith wants to merge 2 commits into
animmosmith wants to merge 2 commits into
Conversation
Old plymouth.ac.uk address is no longer active following a change of employer. Also fixes a malformed pyproject.toml author name field that had the email erroneously appended to it.
The notebook imported pyopia.classify.Classify but never used it. Download the example model via pyopia.exampledata.get_example_model() and add a classifier step to the pipeline config, consistent with single-image-stats-holo.ipynb, so particle classification probabilities are included in the output stats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plymouth.ac.ukaddress is no longer active) inpyproject.tomlandpyopia/instrument/holo.py. Also fixes a malformedpyproject.tomlauthornamefield that had the email erroneously appended to it.notebooks/pipeline-holo.ipynb: the notebook importedpyopia.classify.Classifybut never used it. Now downloads the example model viapyopia.exampledata.get_example_model()and adds aclassifierstep to the pipeline config, consistent withsingle-image-stats-holo.ipynb, so particle classification probabilities are included in the output stats.Test plan
pipeline-holo.ipynbend-to-end viajupyter nbconvert --execute; classifier step runs successfully and output stats includeprobability_*columns