Fix legacy VEmex build compatibility on modern MATLAB/CMake for macOS#33
Open
yasser508 wants to merge 1 commit into
Open
Fix legacy VEmex build compatibility on modern MATLAB/CMake for macOS#33yasser508 wants to merge 1 commit into
yasser508 wants to merge 1 commit into
Conversation
Author
|
PR with some VEmex build script cleanup for newer MATLAB/CMake on macOS. My guess is the issue is in the build config, not runJohansenVE — outdated variable names, wrong MEX extension, macOS-specific naming, stale README. Touched all of those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the VEmex build scripts for modern MATLAB/CMake, mainly to address issue #4 (Apple Silicon linker failure when building the MEX solver for runJohansenVE). There were enough related rough edges nearby that I bundled a few other things in.
Changes
Handle both old and new FindMatlab variable names
Use MATLAB's detected MEX extension when available, with fallbacks for Intel and Apple Silicon on macOS
Drop -pg profiling from the default build — it shouldn't have been on
Fix OpenMP linking for newer CMake versions
Fix a typo in the mex copy/remove step
Use the platform shared library suffix instead of hardcoding .so
Make the MATLAB wrapper symlink command safer
Clearer build instructions in the README
Notes
I don't have MATLAB here so this is all static inspection — no live build test. If someone has a native Apple Silicon + MATLAB setup, a quick smoke test would go a long way. That's the exact environment that started this.
Refs #4