Modify ---NoUI behaviour on Linux, macOS to correctly detach controlling terminal#856
Open
agadsby wants to merge 2 commits into
Open
Modify ---NoUI behaviour on Linux, macOS to correctly detach controlling terminal#856agadsby wants to merge 2 commits into
agadsby wants to merge 2 commits into
Conversation
These changes allow a user to use --NoUI to run Hercules using nohup and & AND get the expected behaviour. These changes have NO impact to Windows users.
Clarify behavior of Hercules on non-Windows platforms when using --NoUI option.
agadsby
requested review from
Fish-Git,
Juergen-Git and
Peter-J-Jansen
as code owners
July 6, 2026 13:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process the --NoUI option early in startup to allow for the controlling tty to be detached (if necessary) and to not try and process a non-readable stdin file.
This allows for the expected behaviour on non Windows platforms when Hercules is started using "nohup" and &.
This is a PARTIAL fix for Issue #849 .
Remaining to be done is retain the logger thread for longer in shutdown so messages are not lost during termination.