Skip to content

Sb/funwave fix wl#34

Open
SBFRF wants to merge 7 commits into
developmentfrom
sb/funwaveFixWL
Open

Sb/funwave fix wl#34
SBFRF wants to merge 7 commits into
developmentfrom
sb/funwaveFixWL

Conversation

@SBFRF

@SBFRF SBFRF commented Jul 22, 2021

Copy link
Copy Markdown
Owner

fixing water level, confirmed that WL is not adjusted in prepdata, and is adjusted in front back

@SBFRF SBFRF requested review from GabySalgado and thesser1 July 22, 2021 16:15
@SBFRF SBFRF self-assigned this Jul 22, 2021

@GabySalgado GabySalgado left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure: you are adding the WL only to r2 and setup, not to the eta time series?

@thesser1

Copy link
Copy Markdown
Collaborator

@SBFRF, why does this say funwave fix wl but it has a bunch of changes to the stwave setup?

@SBFRF

SBFRF commented Jul 23, 2021 via email

Copy link
Copy Markdown
Owner Author

@thesser1

Copy link
Copy Markdown
Collaborator

@SBFRF I don't mind approving it. Doesn't seem to affect anything that I am worried about. I will leave it in your court.

@SBFRF

SBFRF commented Jul 23, 2021 via email

Copy link
Copy Markdown
Owner Author

@SBFRF

SBFRF commented Jul 23, 2021 via email

Copy link
Copy Markdown
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants