feat: offload large payload serialization to worker thread#733
Open
ikalachy wants to merge 2 commits into
Open
feat: offload large payload serialization to worker thread#733ikalachy wants to merge 2 commits into
ikalachy wants to merge 2 commits into
Conversation
When a DataVerticle replies with a JsonArray or JsonObject over the clustered event bus, the Jackson serialization in encodeToWire can block the event loop for large payloads. This change offloads all JSON reply serialization to a worker thread via executeBlocking. A configurable threshold (eventBusLargePayloadThreshold) controls when a warning is logged about large payloads. It defaults to the jsonMaxStringSize value if set, aligning both inbound parsing limits and outbound payload monitoring to the same configured size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a DataVerticle replies with a JsonArray or JsonObject over the clustered event bus, the Jackson serialization in encodeToWire can block the event loop for large payloads. This change offloads all JSON reply serialization to a worker thread via executeBlocking.
A configurable threshold (eventBusLargePayloadThreshold) controls when a warning is logged about large payloads. It defaults to the jsonMaxStringSize value if set, aligning both inbound parsing limits and outbound payload monitoring to the same configured size.