fix: ClassPathScanner — Filter to NeonBee module JARs only#731
Draft
ikalachy wants to merge 1 commit into
Draft
Conversation
1c23add to
f4b6e71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassPathScanner — Filter to NeonBee module JARs only
Overview
This change addresses a blocked thread issue in Kubernetes/Kyma environments where scanForAnnotation blocks a Vert.x worker thread for 87+ seconds reading all JARs on the classpath. The fix pre-filters JARs by checking their manifest for NeonBee-* attributes before doing the expensive filesystem walk.
Correctness
FileSystems.newFileSystem opens it). Not a correctness bug, but a minor inefficiency. Given the goal is to skip 100+ non-NeonBee JARs, the double-read of the few NeonBee JARs is negligible.