Skip to content

feat(servicecredentialbinding): expose name in status#327

Merged
lennardrother merged 3 commits into
mainfrom
323-bug-cf-provider---servicecredentialbinding-creates-service-keys-with-an-unexpected-random-suffix
Jul 15, 2026
Merged

feat(servicecredentialbinding): expose name in status#327
lennardrother merged 3 commits into
mainfrom
323-bug-cf-provider---servicecredentialbinding-creates-service-keys-with-an-unexpected-random-suffix

Conversation

@lennardrother

@lennardrother lennardrother commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR adds the name of the active and retired service credential bindings to the status alongside the already exposed GUIDs.

@lennardrother lennardrother linked an issue Jul 15, 2026 that may be closed by this pull request
[BUG] CF provider - ServiceCredentialBinding creates service keys with an unexpected random suffix #323
Closed
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:45 — with GitHub Actions Inactive
@lennardrother lennardrother added the release-notes/new-feature Marks PR as new feature for release note generation label Jul 15, 2026
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:47 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 07:53 — with GitHub Actions Inactive
n-losse
n-losse previously approved these changes Jul 15, 2026
View reviewed changes
mpechkurov
mpechkurov reviewed Jul 15, 2026
View reviewed changes
Comment thread apis/resources/v1alpha1/servicecredentialbinding_types.go
Comment thread internal/clients/servicecredentialbinding/keyrotator.go Outdated
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 09:36 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 09:37 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 09:37 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 09:37 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 09:37 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 09:37 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 09:37 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 09:37 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 09:44 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:33 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother temporarily deployed to pr-e2e-no-approval July 15, 2026 11:34 — with GitHub Actions Inactive
@lennardrother
lennardrother deployed to pr-e2e-no-approval July 15, 2026 11:40 — with GitHub Actions Active
@lennardrother
lennardrother merged commit 2ed286e into main Jul 15, 2026
35 checks passed
@lennardrother
lennardrother deleted the 323-bug-cf-provider---servicecredentialbinding-creates-service-keys-with-an-unexpected-random-suffix branch July 15, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpechkurov mpechkurov mpechkurov approved these changes
@n-losse n-losse Awaiting requested review from n-losse

Assignees

No one assigned

Labels

release-notes/new-feature Marks PR as new feature for release note generation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] CF provider - ServiceCredentialBinding creates service keys with an unexpected random suffix

3 participants

@lennardrother @mpechkurov @n-losse