fix(combat): armour durability wear targeted the attacker instead of the defender

[CoreyRDean]

The bug (gameplay, runtime-confirmed, found by PR #572's pins)

In ActorAttack's melee path, the "Damage armour" block (GameServer.bb:551-566) iterated A1 (the attacker's) inventory over the armour slots and echoed P_ItemHealth to A1\RNID — but the armour that absorbed the blow is the defender's (all three damage formulas read GetArmourLevel(A2\Inventory)). Net effect: attacking wore down your own armour; the defender's never degraded. Almost certainly a copy-paste of the weapon-wear block above it (:537-549), where A1 is correct. Pinned empirically in #572: defender chest stayed exactly 100 over 300 swings.

The fix

A1 → A2 inside that one block only — the inventory iterated/decremented and the echo recipient. Structure, guards, Rand(1,5) wear rate, slot range, and packet shape unchanged. NPC defenders wear silently under the existing If RNID > 0 convention (same as the weapon block); their armour state stays authoritative server-side.

Wire-routing correctness (verifier-checked): the P_ItemHealth handler (ClientNet.bb:249-252) carries no actor ID — it updates the recipient's own inventory slot. So sending to A2\RNID makes the defending player's client update the same slot the server just decremented in A2's authoritative inventory. Server and client share the SlotI_* constants; the mapping is exact.

Coherence bonus: GetArmourLevel only counts pieces with ItemHealth > 0, so the fix closes the intended loop — the defender's armour degrades and eventually stops protecting the defender (previously, attacking nonsensically degraded the attacker's own defense).

Plus the deliberate flip of the #572 pin: testArmourWearHitsAttackerNotDefender → testArmourWearHitsDefender (defender wears, attacker stays 100; 300 swings × 1-in-5 wear ≈ 60 expected decrements, so the assertions discriminate with enormous margin). The weapon-wear pin is untouched.

Deliberately untouched: the formula-3 vulnerability paradox at :521 (separate, maintainer-gated) and the block's position/conditions (wear still rolls on the melee path exactly where it did).

Out-of-scope observation for a follow-up: the projectile hit path (GameServer.bb:268-304) reads GetArmourLevel(A2\Inventory) but has no armour-wear block at all — ranged hits never wear the defender's armour, before or after this fix.

Verification (independent verifier ≠ implementer)

• Diff = the one block in GameServer.bb (+ comment) and the one test flip; weapon-wear block and :521 byte-identical; no generator-gated files.
• No other consumer of the attacker-wear side effect exists (repair UI, serialisation, BVM accessors all wear-source-agnostic).
• Full suite Ran 58 files: 58 passed, 0 failed.; FULL compile.bat (engine + all 7 tools) exit 0.

🤖 Generated with Claude Code