gccrs: Fix ICE when parsing empty path expression#4558
Merged
Conversation
dkm
reviewed
May 27, 2026
gcc/rust/ChangeLog: * parse/rust-parse-impl.hxx(parse_expr_stmt): Return error early when parse_path_in_expression() returns an error node. Signed-off-by: Yap Zhi Heng <yapzhhg@gmail.com>
CohenArthur
approved these changes
May 28, 2026
Member
CohenArthur
left a comment
CohenArthur
left a comment
There was a problem hiding this comment.
Looks good! Well done. I think your commit message looks good too :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is basically a revival of #3286, that PR can be closed when this gets merged.