[codex] Persist selectable Codex provider paths#1049
Draft
jeffscottward wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1048
Summary
codex-multi-auth-codexbefore plaincodexso NVM/npm multi-auth wrapper installs become the default when present.Validation
npm run build:promptsnpx vitest run src/main/runtime/__tests__/path-prober.shell-path.spec.ts src/__tests__/main/agents/path-prober.test.ts src/__tests__/main/agents/detector.test.ts src/__tests__/renderer/components/shared/AgentConfigPanel.test.tsx src/__tests__/renderer/components/NewInstanceModal.test.tsx --reporter=dotnpm run lintnpm run buildnpm run format:check:allnpm run test(730 passed,1 skipped,28,523 tests passed)npx playwright test e2e/autorun-setup.spec.ts -g "should display the wizard when triggered via keyboard shortcut" --reporter=lineLocal detection check
Verified locally that the built detector selects an NVM-managed
codex-multi-auth-codexwrapper ahead of plaincodex, while still returning Homebrew and NVM plaincodexinstalls as selectable candidates.