Skip to content

fix(installer,workflow): silence /dev/tty noise; bump action-gh-release to v3#35

Merged
chr1syy merged 1 commit into
mainfrom
fix/installer-cosmetic
May 7, 2026
Merged

fix(installer,workflow): silence /dev/tty noise; bump action-gh-release to v3#35
chr1syy merged 1 commit into
mainfrom
fix/installer-cosmetic

Conversation

@chr1syy
Copy link
Copy Markdown
Collaborator

@chr1syy chr1syy commented May 7, 2026

Summary

Cosmetic patches found during the v0.1.2 fresh-install dry-run:

  • `install.sh` — `[ -r /dev/tty ]` returns true in non-interactive contexts (e.g. `bash -c "$(curl ...)"`) where /dev/tty exists but isn't actually openable. The subsequent `</dev/tty` redirect fails and prints `environment: line N: /dev/tty: No such device or address` to stderr. Replace with a real try-open helper `can_read_tty` that uses `{ : </dev/tty; } 2>/dev/null` to test true openability.
  • `.github/workflows/release.yml` — bump `softprops/action-gh-release` from `v2` (Node 20, deprecated, forced upgrade by 2026-06-02) to `v3` (Node 24). Per upstream release notes, v3.0.0 is API-compatible — only the action runtime is bumped.

Bumps to `0.1.3` (patch).

Test plan

  • `npm test` — 169/169 pass
  • Sandbox `bash install.sh` with no TTY: zero `tty: No such` warnings (verified via `grep -c`); installer correctly hits the "Non-interactive shell — writing template" branch
  • After merge: tag `v0.1.3`, verify Release workflow runs cleanly with `action-gh-release@v3` and produces `maestro-relay-v0.1.3.tar.gz`

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores

    • Updated release publishing workflow to v3
    • Version bumped to 0.1.3
  • Improvements

    • Enhanced the installation script to better handle interactive prompts, improving behavior in both automated and manual setups

…se to v3

- install.sh: replace `[ -r /dev/tty ]` (which returns true in
  non-interactive contexts where /dev/tty exists in the namespace but
  isn't actually openable) with a real `can_read_tty` try-open helper.
  Eliminates the four "environment: line N: /dev/tty: No such device or
  address" warnings during `bash -c "$(curl ...)"` installs.
- .github/workflows/release.yml: bump softprops/action-gh-release from
  v2 (Node 20, deprecated) to v3 (Node 24). v3.0.0 is API-compatible
  per upstream release notes; only runtime is bumped.

Bump to 0.1.3.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bb5e536e-a3e8-462d-91be-19537a39410f

📥 Commits

Reviewing files that changed from the base of the PR and between 399ff4d and af299a5.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • .github/workflows/release.yml
  • install.sh
  • package.json

📝 Walkthrough

Walkthrough

This PR centralizes TTY readability detection in the install script by extracting a can_read_tty() helper and refactoring five interactive prompt sites to use it, while bumping the package version to 0.1.3 and upgrading the CI release workflow action to v3.

Changes

TTY Detection Refactor and Release

Layer / File(s) Summary
TTY Detection Helper
install.sh
New can_read_tty() function replaces direct /dev/tty readability checks with a guarded redirect test that suppresses errors in non-interactive contexts.
Core Interactive Prompts
install.sh
prompt_var, write_config, and prompt_yes_no updated to use can_read_tty() instead of direct [ -r /dev/tty ] checks for consistent TTY availability detection.
Voice Model Prompts
install.sh
"Already have a whisper model?" and "enable voice transcription?" interactions now gate behind can_read_tty() instead of direct readability checks.
Version and CI Release
package.json, .github/workflows/release.yml
Package version bumped from 0.1.2 to 0.1.3; GitHub Release action upgraded from @v2 to @v3 with step configuration unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 TTY signals found in the shell so deep,
A helper born to check before we leap,
Five prompts now unified, no more duplication—
Voice flows and configs, all with sanitation!
Release v3 comes with a version chime,
Cleaner install scripts in rhyming time.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately summarizes the main changes: silencing /dev/tty noise in the installer and bumping the GitHub Release action to v3.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/installer-cosmetic

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chr1syy chr1syy merged commit 48afed6 into main May 7, 2026
3 checks passed
@chr1syy chr1syy deleted the fix/installer-cosmetic branch May 7, 2026 18:24
chr1syy added a commit that referenced this pull request May 10, 2026
Brings in installer bugfixes (PRs #33-#35), .maestro/ untrack (#36),
and the docs split (#37) that landed on main after rc was branched.

Conflict resolutions:
- Kept rc's queue error-hiding (PR #39) and per-message logger.error.
- Kept rc's WAL-checkpoint shutdown alongside main's split DB import.
- Combined main's docs split with rc's Slack provider additions in
  README.md, AGENTS.md, .env.example, install.sh, providers.ts,
  migrations.ts.
- Extended config_complete in maestro-relay-ctl.sh to cover the
  Slack key set when ENABLED_PROVIDERS=slack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant