[Main fix][Bug][TractorImplement] Adds missing '-' to large seedbed conditioner entry#3091
Open
ew3361zh wants to merge 4 commits into
Open
[Main fix][Bug][TractorImplement] Adds missing '-' to large seedbed conditioner entry#3091ew3361zh wants to merge 4 commits into
ew3361zh wants to merge 4 commits into
Conversation
[3/3][1.0.0 fix] Collection of 1.0.0 fixes to main
Version Bump to 1.0.2
ew3361zh
requested review from
JoeWaddell,
KFosterReed,
allisterakun and
matthew7838
matthew7838
approved these changes
Jun 11, 2026
matthew7838
left a comment
matthew7838
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, we might still have to update the changelog.
Collaborator
Author
good call - what do we do for changelog entries to fixes that apply to both main and dev? should it just go in the version 1.0 section since it's being patched in there (i.e. it's not a |
JoeWaddell
approved these changes
Jun 12, 2026
JoeWaddell
left a comment
JoeWaddell
left a comment
Collaborator
There was a problem hiding this comment.
Fixes the problem, nice quick work of it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TO BE MERGED INTO
MAINTESTContext
Issue(s) closed by this pull request: closes #3085
What
Added a
-to the large seedbed conditioner tillage implement entry in thetractor_dataset.csv.Why
The
TillageImplementenum forSEEDBED_CONDITIONERexpects the string value to have a-betweenseedbedandconditionerto consider it a match.How
Added the
-to thetractor_dataset.csventry.Test plan
Not able to share the actual inputs here unfortunately and wasn't able to figure out a good set of inputs to replicate this otherwise.
Input Changes
Output Changes
Filter