Fix top-right corner close targets#361
Open
aladin7 wants to merge 1 commit into
Open
Conversation
aladin7
force-pushed
the
fix/320-titlebar-corner-click
branch
2 times, most recently
from
July 21, 2026 19:35
3e459a3 to
9a2e81c
Compare
aladin7
force-pushed
the
fix/320-titlebar-corner-click
branch
from
July 21, 2026 19:48
9a2e81c to
1220173
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
PicView uses custom Avalonia window chrome, and the outermost top-right pixel was outside the effective close target in several window states and dialogs. The native system Close command is disabled for this custom chrome, so returning the standard close hit-test value alone did not activate the close action.
Validation
dotnet build src/PicView.Avalonia.Win32/PicView.Avalonia.Win32.csproj -c Debug -p:Platform=x64— succeeds with 0 errorsgit diff --check upstream/dev...HEADThe repository's full test project is currently blocked by pre-existing stale test mocks and the .NET 11 VSTest/Microsoft Testing Platform mismatch; those files are not changed here.
Fixes #320