Lab 02#44
Open
Dzenonia wants to merge 10 commits into
Open
Conversation
This reverts commit 1ef3ea0.
Rrenkens
reviewed
Dec 28, 2023
|
|
||
| public class Program implements Runnable{ | ||
| private final Model model; | ||
| public Program(String pathToFile) throws IOException { |
Owner
There was a problem hiding this comment.
А зачем помечать его Runnable если это нигде не используется?
|
|
||
|
|
||
| @Override | ||
| public void run() { |
Owner
There was a problem hiding this comment.
А тут зачем помечать что это Runnable и нигде это не использовать?
| } | ||
| } | ||
|
|
||
| public synchronized Integer stealCargo(String cargo, Integer count) { |
Owner
There was a problem hiding this comment.
тут лучше тогда тоже указывать synchronized (currentWeight).
Rrenkens
reviewed
Dec 28, 2023
| private String getLogFileName() { | ||
| SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd_HH-mm-ss"); | ||
| String timestamp = dateFormat.format(new Date()); | ||
| return "lab-02/by/Dzenia/docks_and_hobos/logs/log_" + timestamp + ".log"; |
Owner
There was a problem hiding this comment.
Никогда не вшивайте имена в код, сделайте какой-нибудь доп параметр.
Owner
|
Основная оценка:
Допы:
В итоге: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.