Shurov lab-02#41
Open
MikhailShurov wants to merge 2 commits into
Open
Conversation
Rrenkens
reviewed
Dec 28, 2023
Comment on lines
+12
to
+17
| Tunnel tunnel = new Tunnel(3); | ||
|
|
||
| ShipGenerator shipGenerator = new ShipGenerator(tunnel); | ||
| Thread shipGeneratorThread = new Thread(shipGenerator); | ||
|
|
||
| Integer dockAmount = 4; |
Owner
There was a problem hiding this comment.
Все переменные должны задаваться в файле config.json. Путь до этого файла передается аргументов в вашу программу
Comment on lines
+17
to
+26
| public void addShip(Ship ship) { | ||
| if (tunnel_.size() < maxShips_) { | ||
| tunnel_.add(ship); | ||
| logger.info("Ship added to tunnel. Tunnel size = " + tunnel_.size() + "\n"); | ||
| System.out.println("TUNNEL: Ship added, tunnel size: " + tunnel_.size()); | ||
| } else { | ||
| logger.info("Ship successfully sank\n"); | ||
| System.out.println("TUNNEL: Ship successfully sank"); | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Тут могут возникнуть гонки из-за того что этот метод не синхронизирован, и происходит работа из нескольких потоков с tunnel_.
| @Override | ||
| public void run() { | ||
| while (true) { | ||
| Random random = new Random(); |
Owner
There was a problem hiding this comment.
Зачем на каждую итерацию цикла создавать новый инстанс рандома?
Comment on lines
+45
to
+47
| if (storageCapacity_.get(unloadingShip_.getCargoType()) + unloadingAmountPerSecond_ < maximumStorageCapacity_.get(unloadingShip_.getCargoType())) { | ||
| storageCapacity_.put(unloadingShip_.getCargoType(), storageCapacity_.get(unloadingShip_.getCargoType()) + canBeUnloaded); | ||
| } |
Owner
There was a problem hiding this comment.
Тут же может произойти зацикливание, если товара больше чем нужно и его никак не смогту разгрузить, то сюда не сможет зайти другой корабаль.
| @Override | ||
| public void run() { | ||
| for (int i = 0; i < hobos_.size(); ++i) { | ||
| Thread hubbabubba = new Thread(hobos_.get(i)); |
|
|
||
| boolean allIngredientsCollected() { | ||
| for (String ingredient : portionIngredients_.keySet()) { | ||
| if ((double)portionIngredients_.get(ingredient) != (double)collectedIngredients.get(ingredient)) { |
| HobosCamp hobosCamp_; | ||
|
|
||
| public class HobosCamp implements Runnable { | ||
| HashMap<String, Double> portionIngredients_ = new HashMap<>(); |
| @Override | ||
| public void run() { | ||
| while (true) { | ||
| synchronized (this) { |
Owner
There was a problem hiding this comment.
Зачем здесь синхронизация по this? С этим классом ты нигде больше не работаешь.
| if (!allIngredientsCollected()) { | ||
| for (String ingredient : portionIngredients_.keySet()) { | ||
| if (portionIngredients_.get(ingredient) - collectedIngredients.get(ingredient) != 0) { | ||
| collectedIngredients.put(ingredient, collectedIngredients.get(ingredient) + 1); |
Owner
There was a problem hiding this comment.
А вот тут уже могут быть гонки между collectedIngredients.put и collectedIngredients.get, volatile здесь не поможет.
Owner
|
Основная оценка:
Допы:
В итоге: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Лучшая работа в мире! (мем)