Lab 02#40
Open
mnik0-0 wants to merge 3 commits into
Open
Conversation
Rrenkens
reviewed
Dec 28, 2023
| "unloadingSpeed": 5, | ||
| "dockCapacity": 100, | ||
| "name": "dock2", | ||
| "hoboGroup": { |
Owner
There was a problem hiding this comment.
На все доки только одна общая группа бродяг.
| Gson gson = new Gson(); | ||
| RootObject rootObject; | ||
| try { | ||
| FileReader reader = new FileReader("lab-02/by/mnik0_0/docks_and_hobos/config.json"); |
Owner
There was a problem hiding this comment.
Все переменные должны задаваться в файле config.json. Путь до этого файла передается аргументов в вашу программу
| RootObject rootObject; | ||
| try { | ||
| FileReader reader = new FileReader("lab-02/by/mnik0_0/docks_and_hobos/config.json"); | ||
| rootObject = gson.fromJson(reader, RootObject.class); |
Owner
There was a problem hiding this comment.
Зачем json конвертировать в gson?
Comment on lines
+62
to
+73
|
|
||
| for (int i = 0; i < workers; i++) { | ||
| String type = getTypeToSteal(); | ||
| if (type == null) { | ||
| continue; | ||
| } | ||
| if (!dock.getGoodByType(type)) { | ||
|
|
||
| int count = ingredientsWeNeed.get(type); | ||
| ingredientsWeNeed.put(type, count + 1); | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Вот это должно быть в параллель, а не последовательно.
| return dockCapacity; | ||
| } | ||
|
|
||
| public synchronized boolean getGoodByType(String type) { |
Owner
There was a problem hiding this comment.
Тут тогда лучше переписать на синхронизацию по good.
Owner
|
Основная оценка:
В итоге: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.