cleanup: remove unused mintUrl param from _handlePostResponseBalanceUpdate#12
Open
sh1ftred wants to merge 2 commits into
Open
cleanup: remove unused mintUrl param from _handlePostResponseBalanceUpdate#12sh1ftred wants to merge 2 commits into
sh1ftred wants to merge 2 commits into
Conversation
- Remove v0.1.x version check from fetchAIResponse (already handled in _prepareRoutedRequest) - Remove duplicate balance check from resolveRouteRequestContext (RoutstrClient._checkBalance covers it) - Remove providerRegistry from FetchAIResponseDeps (only used by removed version check) - Remove getProviderManager() from FetchAIResponseClient interface - Export UsageTrackingData from client barrel (was missing) - Fix list-usage-entries.ts: correct import path, add type annotation - Fix routstr-daemon.ts: pass SqliteUsageTrackingDriverOptions, not SdkStore - Fix routstr-cheapest.ts: remove stale providerRegistry from FetchAIResponseDeps - Delete stale fetch-trust-scores.ts (references non-existent project)
…pdate mintUrl was destructured in this method but never referenced in the body. All legitimate consumers (_spendToken, _handleErrorResponse, topUp, refund) continue to receive mintUrl through their own params paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_handlePostResponseBalanceUpdatedestructuredmintUrlfrom its params but never used it in the method body.Trace
mintUrlis still needed and correctly flows through:_spendToken→CashuSpender.spend()_handleErrorResponse→balanceManager.topUp()/balanceManager.refundApiKey()_makeRequest(passthrough to error handler)But in
_handlePostResponseBalanceUpdateit was dead weight.Changes
mintUrlfrom the method's params typemintUrlfrom the destructuringmintUrl: params.mintUrlfrom the single callsite