Prevent image attachments on models that don't support image input#207
Open
bilthon wants to merge 2 commits into
Open
Prevent image attachments on models that don't support image input#207bilthon wants to merge 2 commits into
bilthon wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Today the chat composer lets you attach an image to any model, including text-only ones. Sending that request hits the upstream provider, fails (the model can't accept image input), and still costs sats. This PR gates image attachments to vision-capable models across every entry path, while keeping PDF uploads working everywhere (PDFs are extracted to text client-side and are valid input for text-only models).
A model is treated as image-capable when any of its
architecture.input_modalitiesnormalizes to"image"(via the existingnormalizeModalityhelper.Changes
image/*type hint is removed from theacceptattribute of theinputtag when a model incapable of processing images is selected, thus preventing the user from selecting an image.Closes #171