create the basic test structure and add tests to verify that registration and login are successful - #4
Open
lanovenkyi-web wants to merge 3 commits into
Open
Conversation
…gistration and login are successful
Romapsp
requested changes
May 13, 2026
Owner
There was a problem hiding this comment.
Этот файл нам тоже не нужен. Удаляй
| app.auth.open_login_form() | ||
| app.auth.login(Constants.EMAIL, Constants.PASSWORD) | ||
| app.page.wait_for_load_state("networkidle") | ||
| app.auth.should_be_link_to_profile() No newline at end of file |
Owner
There was a problem hiding this comment.
Название метода не очевидное.
"Должно быть соедининено с профилем"?
| @@ -0,0 +1,5 @@ | |||
| from BugBusters.data.constants import Constants | |||
Owner
There was a problem hiding this comment.
Точно не знаю, но гляньте, может константы тоже можно засунуть в инициализацию и не импортировать их каждый раз.
|
|
||
| def test_create_event_page(app): | ||
| app.event_create.navigate(f"{Constants.BASE_URL}/events/create") | ||
| app.event_create.fill_creation_form("Party") No newline at end of file |
| @@ -0,0 +1,5 @@ | |||
| from BugBusters.data.constants import Constants | |||
|
|
|||
| def test_create_event_page(app): | |||
Owner
There was a problem hiding this comment.
Название теста не очень.
"Создать страницу с событием"
Такого функционала на сайте нет
Comment on lines
+11
to
+14
| def create(self, title, desc): | ||
| self.title_field.fill(title) | ||
| self.desc_field.fill(desc) | ||
| self.page.click('#btn-create') |
Owner
There was a problem hiding this comment.
Мне кажется, этих методов не хватит, чтобы создать мероприятие
Comment on lines
+9
to
+11
| def update_name(self, name): | ||
| self.first_name.fill(name) | ||
| self.page.click('button.save') No newline at end of file |
| def __init__(self, page): | ||
| super().__init__(page) | ||
| self.login_btn = page.locator("a, button").get_by_text("Sign In") | ||
| self.no_account_link = page.get_by_text("Don't have an account", exact=False) |
Owner
There was a problem hiding this comment.
get by text не лучшее решение, когда сайт поддерживает 2 и более языка.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creation of the “Polako Gedonist” core set of automated tests
Addition of the “Authorization” test and the “Registration” test