Skip to content

Fix attendee-blocking issues found in pre-workshop review#2

Open
RoelantD wants to merge 1 commit into
mainfrom
fix/attendee-readiness
Open

Fix attendee-blocking issues found in pre-workshop review#2
RoelantD wants to merge 1 commit into
mainfrom
fix/attendee-readiness

Conversation

@RoelantD

@RoelantD RoelantD commented Jul 8, 2026

Copy link
Copy Markdown
Owner
  • Baseline agents crashed when run in place from baseline/ (yesterday's parent.parent fix regressed the docstring/README run mode): resolve the repo root by looking for the data/ folder, so both run-in-place and copy-to-root work
  • baseline/03-2-agent-memory.py: import order_memory from the repo root first (the name the Part 3 lab uses), fall back to importlib
  • Replace the dead python -m packagemcp fallback (module never shipped) with the finished baseline/06-1-mcp-server.py in all Part 7-10 agents
  • routes.json: PKG-* package IDs did not match packages.json DM-* IDs
  • Part 8/9 parse_label regexes now accept backend-style PKG-2024-* / ROUTE-* IDs like the docs teach (baseline 08 could not parse the documented lab command)
  • Live-API examples and defaults use seeded PKG-2024-* IDs instead of DM-1037/R-2, which do not exist in the package-this backend; MCP tool docstrings the model reads updated the same way
  • README: ten parts (not eight), real filenames for parts 8-10
  • .env.example: document optional PACKAGE_API_URL / PACKAGE_API_PERSONA
  • Drop photo-based wording (multimodal was removed) and fix HITL part number in the MCP design baseline

- Baseline agents crashed when run in place from baseline/ (yesterday's
  parent.parent fix regressed the docstring/README run mode): resolve the
  repo root by looking for the data/ folder, so both run-in-place and
  copy-to-root work
- baseline/03-2-agent-memory.py: import order_memory from the repo root
  first (the name the Part 3 lab uses), fall back to importlib
- Replace the dead `python -m packagemcp` fallback (module never shipped)
  with the finished baseline/06-1-mcp-server.py in all Part 7-10 agents
- routes.json: PKG-* package IDs did not match packages.json DM-* IDs
- Part 8/9 parse_label regexes now accept backend-style PKG-2024-* /
  ROUTE-* IDs like the docs teach (baseline 08 could not parse the
  documented lab command)
- Live-API examples and defaults use seeded PKG-2024-* IDs instead of
  DM-1037/R-2, which do not exist in the package-this backend; MCP tool
  docstrings the model reads updated the same way
- README: ten parts (not eight), real filenames for parts 8-10
- .env.example: document optional PACKAGE_API_URL / PACKAGE_API_PERSONA
- Drop photo-based wording (multimodal was removed) and fix HITL part
  number in the MCP design baseline

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 8, 2026 07:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves several workshop “run as-is” issues by making baseline/starter scripts runnable both in-place (from baseline/ or starter/) and when copied to the repo root, while also aligning example IDs and fallbacks with the current “package-this” backend conventions.

Changes:

  • Make scripts resolve the repo root by detecting the data/ folder so running from baseline//starter/ works reliably.
  • Replace the non-existent python -m packagemcp fallback with baseline/06-1-mcp-server.py across Part 7–10 agents and update related docs/examples.
  • Align IDs and parsing: fix routes.json package IDs, broaden label-parsing regexes to accept PKG-2024-* and ROUTE-*, and update README/.env guidance.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
starter/10-1-hitl-agent.py Fix root resolution and replace dead packagemcp fallback with baseline MCP server.
starter/09-1-a2a-agent.py Same root/fallback update; broaden label parsing to accept PKG-* and ROUTE-*.
starter/08-1-native-tools-agent.py Same root/fallback update; update examples/hints toward seeded backend IDs.
starter/07-1-connected-agent.py Same root/fallback update; update defaults/examples to seeded PKG-2024-* IDs.
starter/06-1-mcp-server.py Update tool docstrings/examples to seeded PKG-2024-* / ROUTE-* IDs.
README.md Update part list to 10 parts and correct starter/baseline filenames and copy workflow.
data/routes.json Fix route package IDs to match data/packages.json (DM-*).
baseline/10-1-hitl-agent.py Same root/fallback update; remove “photo-based” wording from example.
baseline/09-1-a2a-agent.py Same root/fallback update; broaden label parsing to accept PKG-* and ROUTE-*.
baseline/08-1-native-tools-agent.py Same root/fallback update; update examples/hints toward seeded backend IDs.
baseline/07-1-connected-agent.py Same root/fallback update; update defaults/examples to seeded PKG-2024-* IDs.
baseline/06-1-mcp-server.py Update docstrings/examples to seeded PKG-2024-* / ROUTE-* IDs.
baseline/05-1-mcp-design.md Fix HITL segment reference from Part 9 to Part 10.
baseline/03-2-agent-memory.py Prefer importing order_memory from repo root; fix root resolution for data/.
baseline/01-1-first-agent.py Fix root resolution for data/ when running from baseline/.
.env.example Document optional PACKAGE_API_URL / PACKAGE_API_PERSONA.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

print(f" parse_label — {parse_label.__doc__.splitlines()[0]}")
print()
print("MCP tools (served by mcp_server.py / packagemcp):")
print("MCP tools (served by mcp_server.py):")
Comment thread starter/09-1-a2a-agent.py
print(f" parse_label - {parse_label.__doc__.splitlines()[0]}")
print()
print("MCP tools (served by mcp_server.py / packagemcp):")
print("MCP tools (served by mcp_server.py):")
print(f" parse_label — {parse_label.__doc__.splitlines()[0]}")
print()
print("MCP tools (served by mcp_server.py / packagemcp):")
print("MCP tools (served by mcp_server.py):")
print(f" parse_label - {parse_label.__doc__.splitlines()[0]}")
print()
print("MCP tools (served by mcp_server.py / packagemcp):")
print("MCP tools (served by mcp_server.py):")
Comment thread README.md
Comment on lines +45 to +47
Copy the baseline file to this repo's root (`dm-ws/`) under the working name the segment
page uses (for example `copy baseline\06-1-mcp-server.py mcp_server.py`) and continue from
there. Starter files include TODO comments marking exactly what to implement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants