dedup and add all drives scan - #2
Conversation
truefan is a lightweight, web-based fan controller built for Linux systems running lm-sensors. It provides a simple and responsive interface to monitor fan speeds and CPU temperatures, manually apply fan profiles, or restart the system directly from the browser. Built with Flask, it's easy to deploy via Docker or Docker Compose and integrates seamlessly with Dockge, Portainer, and bare-metal setups. Ideal for home labs, servers, or TrueNAS SCALE boxes with custom fan configurations, truefan helps you keep temperatures under control with style.
…ew /set profile route
| return int(float(line.split()[3].replace("+", "").replace("°C", ""))) | ||
| except: | ||
| return 0 | ||
| scan_out = subprocess.check_output(["smartctl", "--scan"], encoding="utf-8") |
There was a problem hiding this comment.
but scanning disks every time is not great, should happen only one time per container startup. I dont think disks change so often...
Also it seems that this file is called run via subprocess in server.py. Why not just import the funcs and call directly?
…; remove SYS_RAWIO; bind loopback; fix fallback keys; catalog-safe hardening
|
Thanks for the thoughtful review — all good points. Regarding smartctl JSON output: agreed. Switching to JSON parsing instead of string splitting is the right move. It will make the temperature parsing more reliable and future-proof against formatting changes. I’ll update the implementation to use smartctl -j and parse the JSON payload instead of relying on positional splits. On disk scanning frequency: you’re absolutely right. Scanning on every request is unnecessary and inefficient. I’ll refactor this so disk enumeration happens once at container startup and is cached, with periodic refresh only if needed. That will reduce overhead and keep runtime behavior predictable. As for calling via subprocess from server.py: good catch. That’s legacy from an earlier structure. Refactoring to import the functions directly and call them natively will be cleaner and avoids unnecessary process spawning. I’ll consolidate that to keep everything in-process. Appreciate the detailed feedback — this improves both performance and maintainability. |
3 participants
Hi there thanks for the initiative. I would love to add more functionality with regards to letting the fan curve be determined based on the drive temps. I dedupped the logic and extended the drive scanning.