# fix: unblock Dependabot Security Updates (Node 24 Compat + brace-expansion CVE)#1296
# fix: unblock Dependabot Security Updates (Node 24 Compat + brace-expansion CVE)#1296Aryan-Verma-999 wants to merge 2 commits into
Conversation
|
Any specific reason why it was working fine with 16.9 node version without any failures? |
|
I suggest we also switch to 24, as it's the LTS too version with much longer support. Is there any specific reason you chose 22? I hope migrating from 22 to 24 won't be a major task. |
|
primary reason for choosing 22 was to align embeddedchat with rc server, as rc 8.4+ requires node 22 |
|
Got it! But I think we should still move to 24, as Rocket.Chat is constantly maintained by the internal team. Once the support ends, it will probably be migrated. EmbeddedChat, on the other hand, is more of a community-maintained project, so it's difficult to make major changes later on. So let's go with the latest LTS version. |
the old node-check.js used minimum version check, that's why the dependabot was failing |
yeah sure, on it |
Understood! |
|
Closing this PR. If, later, dependabot fails, we'll think about it. |
fix: Unblock Dependabot Security Updates (Node 24 Compat + brace-expansion CVE)
Acceptance Criteria fulfillment
node-check.jsskips the Node.js version enforcement when running inside Dependabot's container (DEPENDABOT_HOMEis set), preventingYN0009build failurespostinstallbuild step is skipped in Dependabot and CI environments socorepack yarn upcan complete without triggering a full monorepo buildhandlebars,vm2,path-to-regexp, andnode-forgeare unblocked (previously failing because Dependabot runs Node.js v24 whilenode-check.jsenforced Node 22)brace-expansionCVE in/packages/react-nativeis addressed by pinning to1.1.13via yarnresolutionsVideo/Screenshots
No UI changes — infrastructure/tooling fix only.
PR Test Details
Root cause: Dependabot's updater container runs Node.js v24.15.0, but
scripts/node-check.jsenforced Node 22 (major version check), causingexit code 1→YN0009: embeddedchat@workspace:. couldn't be built successfullyon every Dependabot security update attempt against the root workspace.Changes:
scripts/node-check.jsDEPENDABOT_HOMEenv var is setpackage.jsonpostinstall: yarn buildin Dependabot and CI environmentspackages/react-native/package.jsonresolutionsto pinbrace-expansionto1.1.13Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1296 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.