[pull] main from Pennyw0rth:main#373
Merged
Merged
Conversation
Signed-off-by: e-nzym3 <jack@enzym3.io>
Replaces the single GENERIC_WRITE check with a multi-mask approach covering FILE_ADD_FILE, FILE_ADD_SUBDIRECTORY, WRITE_DAC, and WRITE_OWNER. Plain WRITE suppresses the more granular labels when redundant. Dynamic column widths added.
…fe_shares module safe_shares is superseded by ACL-based write detection now built into --shares.
… queue) using shi1_type
- Import write-check masks from impacket.smb3structs instead of redefining locally - Move write_checks list into shares() scope - Enforce --file-write-check requires --shares via argparse make_required - Use STYPE_DISKTREE/STYPE_MASK constants for share type check; store type in share_info - Add debug log when skipping non-filesystem shares - Restore explanatory comment on empirical write check - Replace try/except/pass with contextlib.suppress on disconnectTree - Rename column-width vars and explain magic numbers in shares output
Add safe_shares SMB module: share permission enumeration module that does not write files to disk
QoL DPAPI - Log message when empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )