Skip to content

Display bug: Tag changes in HTML template #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
attoPascal wants to merge 1 commit into from
Closed

Display bug: Tag changes in HTML template #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions styles/prosilver/template/show_tag.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,11 @@ <h2 class="forum-title">{RH_TOPICTAGS_SEARCH_HEADER}</h2>
<!-- EVENT viewforum_body_topic_row_before -->
<li class="row<!-- IF topicrow.S_ROW_COUNT is even --> bg1<!-- ELSE --> bg2<!-- ENDIF --><!-- IF topicrow.S_POST_GLOBAL --> global-announce<!-- ENDIF --><!-- IF topicrow.S_POST_ANNOUNCE --> announce<!-- ENDIF --><!-- IF topicrow.S_POST_STICKY --> sticky<!-- ENDIF --><!-- IF topicrow.S_TOPIC_REPORTED --> reported<!-- ENDIF -->">
<!-- EVENT viewforum_body_topic_row_prepend -->
<dl class="row-item {topicrow.TOPIC_IMG_STYLE}">

@RobertHeim RobertHeim Mar 27, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the source of your comparison? As on the official phpbb 3.2.x branch [1], the dl tag has the class="row-item"
[1] https://github.com/phpbb/phpbb/blob/3.2.x/phpBB/styles/prosilver/template/viewforum_body.html#L158

@attoPascal attoPascal Mar 28, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it appears to be a quirk of the we_universal theme: https://github.com/melvingb/we_universal/blob/master/template/viewforum_body.html#L157

Still, it's one of the most popular ones, pity that it doesn't work out of the box.

<dt<!-- IF topicrow.TOPIC_ICON_IMG and S_TOPIC_ICONS --> style="background-image: url({T_ICONS_PATH}{topicrow.TOPIC_ICON_IMG}); background-repeat: no-repeat;"<!-- ENDIF --> title="{topicrow.TOPIC_FOLDER_IMG_ALT}">

@RobertHeim RobertHeim Mar 27, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not true, see https://github.com/phpbb/phpbb/blob/3.2.x/phpBB/styles/prosilver/template/viewforum_body.html#L159

<dl title="{topicrow.TOPIC_FOLDER_IMG_ALT}">
<dt<!-- IF topicrow.TOPIC_ICON_IMG and S_TOPIC_ICONS --> style="background-image: url({T_ICONS_PATH}{topicrow.TOPIC_ICON_IMG}); background-repeat: no-repeat;"<!-- ENDIF --> class="row-item {topicrow.TOPIC_IMG_STYLE}">
<!-- IF topicrow.S_UNREAD_TOPIC and not S_IS_BOT --><a href="{topicrow.U_NEWEST_POST}" class="row-item-link"></a><!-- ENDIF -->
</dt>
<dd>
<div class="list-inner">
<!-- EVENT topiclist_row_prepend -->
<!-- IF topicrow.S_UNREAD_TOPIC and not S_IS_BOT -->
Expand Down Expand Up @@ -108,7 +110,7 @@ <h2 class="forum-title">{RH_TOPICTAGS_SEARCH_HEADER}</h2>

<!-- EVENT topiclist_row_append -->
</div>
</dt>

@RobertHeim RobertHeim Mar 27, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not true, see https://github.com/phpbb/phpbb/blob/3.2.x/phpBB/styles/prosilver/template/viewforum_body.html#L222

</dd>
<dd class="posts">{topicrow.REPLIES} <dfn>{L_REPLIES}</dfn></dd>
<dd class="views">{topicrow.VIEWS} <dfn>{L_VIEWS}</dfn></dd>
<dd class="lastpost">
Expand Down