Conversation
There was a problem hiding this comment.
Pull request overview
Updates this project’s raylib/Umka integration to align with newer upstream versions (raylib 6.x and Umka 1.5.x), adjusting code generation and runtime glue so examples/tests can run again.
Changes:
- Bumped project/tooling versions and updated dependencies (raylib + Umka, generator schema inputs).
- Updated the Umka runtime invocation code in
bin/raylib-umka.cto newer Umka API patterns. - Adjusted generator type mappings/struct field handling and tweaked a lifecycle assertion in the Umka test.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/raylib-umka-tests.um | Removes a post-CloseWindow() readiness assertion in the lifecycle test. |
| package.json | Version bump; script refactor; switches @raylib/api to a GitHub ref; bumps gh-pages. |
| generator/index.js | Updates struct/type mappings and field-name escaping for Umka codegen; updates dependency docs. |
| CMakeLists.txt | Version bump to 0.6.0. |
| cmake/Findumka.cmake | Updates fetched Umka tag/version to v1.5.5. |
| cmake/Findraylib.cmake | Pins raylib FetchContent GIT_TAG to a specific commit SHA. |
| bin/raylib-umka.c | Updates to new Umka function call/get-error APIs and adjusts web update callback call signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something is keeping it from running.