Week 5 testing#75
Conversation
…er-service architecture
…and migrate to RESTful routing
…items, total_pages)
…or Product endpoints
…ules with structured error handling
…rchitecture refactor)
… to MongoEngine ORM, add request/response models and audit fields (advanced section implemented as well)
…advanced filtering APIs
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| created_at = DateTimeField(default=datetime.utcnow) | ||
| def save(self, *args, **kwargs): | ||
| self.updated_at = datetime.utcnow() | ||
| return super().save(*args, **kwargs) |
There was a problem hiding this comment.
Product model missing updated_at field declaration
High Severity
The Product model never declares updated_at as a DateTimeField, unlike ProductCategory which properly declares it. The save() override sets self.updated_at as a plain Python attribute, but since Product extends Document (not DynamicDocument), MongoEngine won't persist it to MongoDB. This means to_dict() will fail with an AttributeError when reading a product from the database, and the repository's list_updated_after query on updated_at__gt will never match anything.
Additional Locations (1)
| message=updated["error"] | ||
| if isinstance(message, list): | ||
| message = message[0] | ||
| return error_response("VALIDATION_ERROR", updated["error"], status=400) |
There was a problem hiding this comment.
PUT handler passes original error instead of extracted message
Medium Severity
In the PUT handler, the code extracts updated["error"] into message and converts it from a list to its first element if needed, but then passes the original updated["error"] to error_response instead of the corrected message variable. The analogous POST handler and bulk upload handler both correctly pass message. If the error is a list, this sends the raw list as the error message instead of a string.
|
|
||
| result = ProductCategoryService.list_categories() | ||
|
|
||
| self.assertEqual(result, []) No newline at end of file |
There was a problem hiding this comment.
Test file redefines service class, shadowing import
Medium Severity
This test file declares a local class named ProductCategoryService (line 12), which shadows the imported service from line 7. This class is a full copy of the real service, not a unittest.TestCase subclass. The two test methods (test_create_category_none_title and test_list_categories_empty) are defined as methods of this duplicate service class, so no test runner will discover or execute them. The file contains no actual runnable tests.
| description = StringField() | ||
|
|
||
| created_at = DateTimeField(default=datetime.utcnow) | ||
| updated_at = DateTimeField(default=datetime.utcnow) |
There was a problem hiding this comment.
ProductCategory.updated_at never updates after creation
Low Severity
ProductCategory.updated_at is declared with default=datetime.utcnow but has no save() override to refresh it on updates, unlike the Product model which attempts to do this. When a category is updated via update_category, the updated_at field retains its original creation-time value. The to_dict() method exposes this stale timestamp to API consumers.
Additional Locations (1)
…s for ProductService/ProductCategoryService with mocking; implemented integration tests with Django and MongoDB; refactored tests to use seed command; added negative/parameterized test cases; created seed_categories command; added regression script (run_tests.bat); configured .env; improved assertions. ~69%% coverage
3 participants
Hi, I’ve pushed my Week 5 work on a separate branch
week-5-testingand created a pull request. Could you please review it when you get time? I’ve also added integration tests and logging as part of this update.Note
High Risk
Adds new MongoDB-backed CRUD and bulk-upload endpoints plus auto-seeding on Django startup, which impacts data integrity and runtime behavior. Also introduces
csrf_exemptroutes and a hardcoded Mongo connection string, increasing security/configuration risk.Overview
Introduces a new Products/Categories API backed by MongoEngine, including product CRUD, pagination/filtering (
category,price_min/max,updated_after), category CRUD, and endpoints to list/assign/remove a product’s category plus a CSV bulk upload (/products/bulk/).Adds supporting layers (models, repositories, services), standardizes API responses via
success_response/error_response, and replaces thehello/response with a query-parameter greeting.Wires MongoDB connection and category seeding into
settings.py, adds logging, includes a one-off migration script to backfill missing categories, and adds unit/integration tests covering controllers/services and basic API flows.Written by Cursor Bugbot for commit 2095141. Configure here.