[EPAC-1979]: apply adaptive reading width to long-form lists#690
Merged
github-actions[bot] merged 1 commit intoMay 28, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer-Boundary: review-only
Resolves EPAC-1979
Why
Long-form reading surfaces in the iPad/macOS layout were still stretching across regular-width panes after the adaptive layout primitives landed. This applies the existing 720pt
adaptiveReadingWidthcap where the app presents Hansard chat, feed cards, petitions, search result bodies, bill/expenditure details, and member profile/voting content.What changed
.adaptiveReadingWidth()to the named long-formListcontainers in Bills, Expenditures, Home, Petitions, and member voting views.MemberProfileViewscroll content in an inner container and applied the modifier there, preserving theScrollViewitself.Trade-offs not taken
Test plan
python3 scripts/localization/check_localizations.py --github-warningscd ios && make buildgit diff --check origin/main...HEADcd ios && make testbuilt and ran tests, andAdaptiveLayoutTestsplus the later smoke UI tests passed. The full target exitedError 65from existing failures: snapshot mismatches inSnapshotTests(DataSourceBadge_*,PartyBadge_allParties,Settings_root), broad non-layout unit failures reported after the first failed run, andOnboardingAndFirstDebateUITests.test_freshInstall_dismissesOnboarding_opensFirstDebatewithApplication net.dinglebox.cabinetdoor is not running.cd ios && swiftlint --strictreports 1010 existing repository-wide violations. A changed-file lint pass also reports pre-existing style violations in touched files; the new modifier lines do not introduce syntax/build issues.Screenshots
Not attached from this run. Local build verification passed, but the full test/visual automation path is currently blocked by the unrelated baseline failures listed above. EPAC-1980 now contains the required human iPad landscape Hansard chat visual-QA item.
Release-Note: Improves iPad and Mac readability by keeping long-form civic content at a comfortable reading width.