[EPAC-1978]: switch sheets to adaptive form presentation#689
Merged
github-actions[bot] merged 1 commit intoMay 28, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer-Boundary: review-only
Scope
regularSizeClassFormSheetso regular horizontal size classes use form-style sheet sizing with medium/large detents and a visible drag indicator.Bugfix SPEC
Testing notes
cd ios && make test TEST_ONLY=AdaptiveLayoutTests— passed, 2 tests.cd ios && make build— passed.python3 scripts/localization/check_localizations.py --github-warnings— passed.swiftlint --strict <9 touched Swift files>— passed with 0 violations.swiftlint --strictwas run and failed on pre-existing violations outside this change set, includingios/epacUITests/AppPreviewRecordingTests.swift:12,ios/epac/Model/CabinetService.swift:27, widget/app-clipno_magic_numbers, andios/epacTests/WorkflowSafetyTests.swift:22.cd ios && make ipad-simulator— built, installed, and launched on iPad Pro 13-inch (M5) simulator. Local screenshot captured at/tmp/epac-1978-evidence/ipad-launch-600.png.Screenshots
/tmp/epac-1978-evidence/ipad-launch-600.png.Related issue
Release-Note: iPad and regular-width modal sheets now use a form-style presentation with medium and large detents.