Skip to content

Add cancel dialog event listener & Export FeedbackService, FeedbackDirective#13

Open
workfel wants to merge 55 commits into
RickonChen:masterfrom
digikare:master
Open

Add cancel dialog event listener & Export FeedbackService, FeedbackDirective#13
workfel wants to merge 55 commits into
RickonChen:masterfrom
digikare:master

Conversation

@workfel

@workfel workfel commented Nov 20, 2019

Copy link
Copy Markdown
  • I need service to force re-render the screenshot, because before set screen image i need to hide all private user information.

@artar94

artar94 commented Dec 23, 2019

Copy link
Copy Markdown

@workfel I think it would be great to make another service specifically for export.
It should have only one method feedback(): Observable<Feedback>, which, if successful, returns Feedback, and if canceled, returns an error.
This will allow you to use this library with any buttons and directives, not just the built-in one, and it will not force the user to deal with the internal organization of the initScreenshotCanvas, setFeedback, openFeedbackDialog, etc. methods.

@workfel

workfel commented Dec 23, 2019

Copy link
Copy Markdown
Author

ok, but why don't juste export the current Service ?

@artar94

artar94 commented Dec 23, 2019

Copy link
Copy Markdown

I have nothing against it, but I would recommend at least renaming the current FeedbackService to FeedbackInternalService so that the new service has a user-friendly name.

@workfel

workfel commented Dec 23, 2019

Copy link
Copy Markdown
Author

Ok, i just updated the PR

spike008t and others added 29 commits December 14, 2020 16:30
WIP: Fix/angular 8 & 9 compat - bump 2.0.0
Looks like on es5 the string has a limit size of ~2Mb..
The image generated is cropped..
Fix/buffer size image & bump v2.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants