Fix Letterboxd TMDB link selector#64
Open
CameronGarrett wants to merge 1 commit into
Open
Conversation
Letterboxd removed the `data-track-action="TMDB"` attribute from their TMDB links, causing `tmdbURL` to be undefined and crashing the content script with `TypeError: can't access property "includes", tmdbURL is undefined`. Add a fallback selector that matches by href containing "themoviedb.org". The original data-attribute selector is preserved for backwards compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-track-action="TMDB"attribute from their TMDB links, breaking the extension on all Letterboxd film pageshrefcontainingthemoviedb.orgDetails
The current selector:
returns nothing on Letterboxd film pages because the TMDB link no longer has a
data-track-actionattribute. This causestmdbURLto beundefined, crashing at line 11:The fix adds a fallback:
Test plan
data-track-actionattribute is present