Fix SAT/SAT3 verifiers: || operator and CertificateParseException#314
Merged
wrigjl merged 1 commit intoJun 19, 2026
Merged
Conversation
Both verifiers used bitwise | instead of logical || when comparing string values for True/False assignments. While functionally equivalent today (no side effects), it signals a misunderstanding and is corrected to ||. SATVerifier additionally had no error handling: malformed assignments (missing separator, unknown boolean value, empty certificate) were silently ignored. It now throws CertificateParseException on any parse failure, matching SAT3Verifier's existing behavior. SAT_Class gains a validateInstance() guard in its non-default constructor, mirroring the same guard already in SAT3_Class. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
| vs || is subtle.... love it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both verifiers used bitwise | instead of logical || when comparing string values for True/False assignments. While functionally equivalent today (no side effects), it signals a misunderstanding and is corrected to ||.
SATVerifier additionally had no error handling: malformed assignments (missing separator, unknown boolean value, empty certificate) were silently ignored. It now throws CertificateParseException on any parse failure, matching SAT3Verifier's existing behavior.
SAT_Class gains a validateInstance() guard in its non-default constructor, mirroring the same guard already in SAT3_Class.