Add empty-solution guards to TSP and Hamiltonian visualizations#313
Merged
wrigjl merged 1 commit intoJun 19, 2026
Merged
Conversation
SolvedVisualization() called parseNodeListWithStringFunctions without
checking whether solve() returned an empty result. An empty or "{}"
solution caused TSP to incorrectly color every graph node as Solution
(the all-nodes loop ran unconditionally) and left both visualizations
open to operating on a single-element list containing an empty string.
The guard returns the unsolved graph view immediately when the solution
is empty, "{}", or produces no valid node names after parsing.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
wrigjl
deleted the
bugfix/tsp-hamiltonian-visualization-empty-solution-guard
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SolvedVisualization() called parseNodeListWithStringFunctions without checking whether solve() returned an empty result. An empty or "{}" solution caused TSP to incorrectly color every graph node as Solution (the all-nodes loop ran unconditionally) and left both visualizations open to operating on a single-element list containing an empty string.
The guard returns the unsolved graph view immediately when the solution is empty, "{}", or produces no valid node names after parsing.