Fix Knapsack and NQueens verifiers to throw CertificateParseException#312
Closed
Trosper3 wants to merge 1 commit into
Closed
Fix Knapsack and NQueens verifiers to throw CertificateParseException#312Trosper3 wants to merge 1 commit into
Trosper3 wants to merge 1 commit into
Conversation
Both verifiers had bare `catch { return false; }` blocks that silently
swallowed parse errors, giving callers no indication of why a
certificate was rejected. They now re-throw CertificateParseException
(passthrough if already that type, otherwise wrapping the underlying
exception with the certificate string and a detail message), matching
the codebase-wide convention established in other verifiers.
KnapsackVerifier.parseCertificate also updated to throw
CertificateParseException with a descriptive message instead of a bare
Exception when an item is not in the problem's item set.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both verifiers had bare
catch { return false; }blocks that silently swallowed parse errors, giving callers no indication of why a certificate was rejected. They now re-throw CertificateParseException (passthrough if already that type, otherwise wrapping the underlying exception with the certificate string and a detail message), matching the codebase-wide convention established in other verifiers.KnapsackVerifier.parseCertificate also updated to throw CertificateParseException with a descriptive message instead of a bare Exception when an item is not in the problem's item set.