Fix HittingSet solver IndexOutOfRange / missed-item loop bound#311
Merged
Conversation
The inner loop iterated hittingSet.subSets.Count() + 1 times while indexing into items (the universalSet). When the universal set size differs from subsets count the loop either crashes with IndexOutOfRangeException or stops before processing every candidate. The possibleSolution list is already sized by items.Count, so use that as the bound. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
When you find bugs like this, see if you can create a unit test that fails before your fix and succeeds afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inner loop iterated hittingSet.subSets.Count() + 1 times while indexing into items (the universalSet). When the universal set size differs from subsets count the loop either crashes with IndexOutOfRangeException or stops before processing every candidate. The possibleSolution list is already sized by items.Count, so use that as the bound.