ProblemProvider: IActionResult + key validation on all endpoints#304
Open
wrigjl wants to merge 1 commit into
Open
ProblemProvider: IActionResult + key validation on all endpoints#304wrigjl wants to merge 1 commit into
wrigjl wants to merge 1 commit into
Conversation
- Add [ApiController] so missing required query params return 400
before the method body runs (fixes NullReferenceException and
KeyNotFoundException crashes seen in console)
- Convert all string-returning endpoints to IActionResult
- Add TryGetValue guard on every endpoint so unknown names return
{ error, received } 400 instead of an unhandled KeyNotFoundException
- Cache Visualization instance in visualize() instead of calling
Visualization() three times
- Replace throw ArgumentException in visualizeReduction with BadRequest
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[ApiController]toProblemProviderso missing required query params return a framework-level 400 before the method body runs — fixes theNullReferenceExceptionandKeyNotFoundExceptioncrashes that were showing up in the consolestring-returning endpoints (info,visualize,visualizeReduction,reduce,mapSolution,gadgets) toIActionResultfor consistency withverify,solve, andproblemInstanceTryGetValueguard on every endpoint so an unknown name returns{ error, received }400 instead of an unhandled exceptionVisualizationinstance invisualize()instead of constructing it three timesthrow ArgumentExceptioninvisualizeReductionwithBadRequestTest plan
dotnet build API.csproj— 0 errors, same pre-existing warnings as baselinedotnet test redux-tests/— 555/555 passed🤖 Generated with Claude Code