Add global PnR candidate smoke#42
Merged
Merged
Conversation
57b3106 to
b0f66cb
Compare
# Conflicts: # src/transform/place_and_route/local_placer/mod.rs
Problem: D flip-flop NBT could start flickering after the sequence #1 on, #2 on, #2 off, #2 on. The latch feedback torches burned out during initialization, but the simulator cleared or aged out that burnout state, so the same feedback loop recovered later and oscillated again. Fix: keep torch burnout as a simulator-session stabilization state, schedule torch reevaluations through the queue, and re-read the support cobble power when the delayed torch event is applied. This prevents stale support observations and prevents burned-out feedback torches from recovering mid-session. Verification: cargo test --release world::simulator::test -- --nocapture; cargo run --release --bin repro_toggle -- test/d-flip-flop-global-smoke.nbt; npm.cmd run build:wasm.
b0f66cb to
b830774
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification