Fix hardcoded paths with environment variables#4
Merged
Conversation
- cmm-docs-mcp: Replace hardcoded /Users/wash198/... path with CMM_DOCS_DATA_ROOT env var for the directory containing OSTI_retrieval, schemas, USGS data, etc. - cmm-fine-tune: Replace brittle parents[4] relative path with CMM_FINETUNE_DATA_ROOT env var for the directory containing API_Scripts and fine_tuning subdirs. Both packages now gracefully degrade when env vars are not set (paths resolve to empty, and code already handles missing files). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/Users/wash198/...absolute path inconfig.pywithCMM_DOCS_DATA_ROOTenv var. This was a deployment blocker — the path only worked on one machine.Path(__file__).resolve().parents[4]inconstants.pywithCMM_FINETUNE_DATA_ROOTenv var. Theparents[4]assumption was incorrect after the monorepo migration.Both packages gracefully degrade when env vars are unset — paths resolve to empty and the existing code already checks
.exists()before accessing files.Environment variables
CMM_DOCS_DATA_ROOTOSTI_retrieval/,schemas/,USGS_Data/, etc.CMM_FINETUNE_DATA_ROOTAPI_Scripts/andfine_tuning/Verification
Test plan
uv run ruff check packages/passesuv run mypy packages/passes🤖 Generated with Claude Code