Fix critical gaps: deps, license, integration tests#3
Merged
Conversation
- Add torch and numpy dependencies to cmm-embedding/pyproject.toml - Add MIT LICENSE file at repo root (referenced in pyproject.toml) - Mark cmm-fine-tune data-dependent tests with @pytest.mark.integration - Add pytest.skip guards for missing external CSV data files - Register integration marker and deselect by default in pytest config Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torch>=2.0andnumpy>=1.24topackages/cmm-embedding/pyproject.toml(was emptydependencies = [])LICENSEfile (referenced bylicense = "MIT"in pyproject.toml but was missing)@pytest.mark.integrationand addedpytest.skip()guards for missing external CSV files. These tests are deselected by default viaaddopts = "-m 'not integration'"and can be run withpytest -m integrationVerification
Test plan
uv run ruff format --check packages/passesuv run ruff check packages/passesuv run mypy packages/passesuv run pytest— 489 passed, 0 faileduv run pytest -m integration— runs integration tests when CSV data is available🤖 Generated with Claude Code