fix: resolve all 173 mypy type errors across 8 packages#1
Merged
Conversation
Fix type annotations, casts, and signatures across 34 files in all workspace packages to achieve zero mypy errors. Key changes: - cmm-embedding (71): async generator types, missing dataclass args, numpy float casts, dataclass field ordering - cmm-data (31): BaseLoader.load() override signatures (**kwargs), no-any-return casts, catalog variable types - bgs-mcp (23): dict type annotations, float/int conversions, sorted key lambdas - cmm-fine-tune (19): yaml type-ignore, float|None guards, unpack fix - uncomtrade-mcp (12): httpx params typing, Collection[str] fixes - arxiv-mcp (7): None guards, no-any-return casts - scholar-api (5): dict type annotations - claimm-mcp (5): pydantic-settings type-ignore, lambda key fix No public APIs or runtime behavior changed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Errors fixed by package
categoryargs, numpy float casts, dataclass field orderingBaseLoader.load()override signatures (**kwargs),no-any-returncasts, catalog variable typessortedkey lambdasyamltype-ignore,float|Noneguards, unpack fix for 3-value returnCollection[str]→ typed dicts.strip()/.split(),no-any-returncaststype: ignore[misc]on heterogeneous comprehensiontype: ignore[call-arg], lambda key fixTest plan
uv run mypy packages/— 0 errors (was 173)uv run ruff check packages/— all checks passeduv run ruff format --check packages/— all formatteduv run pytest— 37 passed, 10 failed (pre-existing, missing data files), 2 skipped🤖 Generated with Claude Code