Skip to content

dummy change to enable ci run#86

Open
TalBarYakar wants to merge 3 commits into
masterfrom
tal.ba/feat/check_master_ci
Open

dummy change to enable ci run#86
TalBarYakar wants to merge 3 commits into
masterfrom
tal.ba/feat/check_master_ci

Conversation

@TalBarYakar
Copy link
Copy Markdown
Contributor

@TalBarYakar TalBarYakar commented Mar 18, 2026

Note

Low Risk
Low risk build-system change; the main impact is on macOS bindgen/CI behavior and could affect header parsing if the sysroot detection is wrong.

Overview
Updates the Rust build tooling by bumping bindgen to 0.72 and adjusting build.rs to pass an Xcode SDK sysroot (xcrun --show-sdk-path) to bindgen/clang on macOS.

Includes a no-op formatting change in src/cluster.h (extra blank line) with no functional impact.

Written by Cursor Bugbot for commit aff932a. This will update automatically on new commits. Configure here.

Pass macOS SDK sysroot to bindgen's clang args so Homebrew's
LLVM can properly parse C types instead of falling back to
opaque structs with only `_address`.
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread build.rs Outdated
@TalBarYakar TalBarYakar force-pushed the tal.ba/feat/check_master_ci branch from 2d93d53 to aff932a Compare March 18, 2026 16:34
@gabsow
Copy link
Copy Markdown
Contributor

gabsow commented Mar 19, 2026

Diff in /home/runner/work/LibMR/LibMR/build.rs:50:
}
}

  • let bindings = build
  •    .generate()
    
  •    .expect("error generating bindings");
    
  • let bindings = build.generate().expect("error generating bindings");

    let out_path = PathBuf::from(&output_dir);
    bindings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants