Skip to content

Added async writes / batching by default#1

Closed
doomerhunter wants to merge 3 commits into
Redguard:masterfrom
AllVei-Hackbot:doomerhunter-async
Closed

Added async writes / batching by default#1
doomerhunter wants to merge 3 commits into
Redguard:masterfrom
AllVei-Hackbot:doomerhunter-async

Conversation

@doomerhunter

Copy link
Copy Markdown

Hi there :)

First, thanks for taking the time to maintain this extension and for the rewrite under the montoya API :)

In the past, when using the extension on large bug bounty targets and extensive sessions, I had some performance issues, notably with scans or when browsing in parallel with different browsers / sessions.

I would like to implement a couple of new features in this extension amongst which :

  • 1/Async writes to the DB
  • 2/The ability to batch push requests to a postgreSQL database.
  • 3/Some additional configuration options on the type of traffic to be logged (ex: being able to exclude intruder traffic temporarly)

This pull request implements 1/Async writes to the DB by modifying src/main/java/burp/ActivityLogger.java

Disclosure: I (really) suck at Java, so this code was generated through the help of Claude 4. I then proceeded to test the code through building it and stress-testing the extension (multiple browsers, directory brute-force through intruder...).

@dominiqueroux dominiqueroux self-requested a review June 17, 2025 14:14
@dominiqueroux dominiqueroux self-assigned this Jun 17, 2025
@dominiqueroux dominiqueroux added the enhancement New feature or request label Jun 17, 2025
@dominiqueroux

dominiqueroux commented Jun 17, 2025

Copy link
Copy Markdown
Collaborator

Hi @doomerhunter

First of all, thank you very much for your contributions. I really appreciate and honestly, did not think that anyone would contribute in that short time after the transfer of ownership :).

In my opinion, it would be best to have separate PR for each new feature. This way we could discuss the points in a modular way and do not block other features. Therefore, I will close #4 without merging. I hope that is fine for you. Furthermore, would it be possible for you to "untangle" the different PRs? I currently see here the commits "First iteration of the tool filtering feature" and "added a better interface to select the tools we wish to include". Thus, this PR already contain two different features.
Secondly, I would need to discuss some organizational matter with you; would it be possible to write me an email? (My email is dominique.roux@protonmail.com)

For this specific feature: I will check out the code and also do some testing prior to merging. The general feature sounds nice and I have no general objection or remarks there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants